Clone kafka 18894 #34

DDShantanuBadmanji · 2025-10-01T11:55:09Z

Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.

If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.

If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.

coderabbitai · 2025-10-01T11:55:16Z

Warning

Rate limit exceeded

@DDShantanuBadmanji has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ed79212 and 5989a26.

📒 Files selected for processing (13)

Vagrantfile (1 hunks)
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java (4 hunks)
clients/src/main/java/org/apache/kafka/common/config/ConfigTransformer.java (3 hunks)
clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java (1 hunks)
clients/src/test/java/org/apache/kafka/common/config/ConfigTransformerTest.java (5 hunks)
clients/src/test/java/org/apache/kafka/common/config/provider/MonitorableConfigProvider.java (1 hunks)
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java (2 hunks)
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java (1 hunks)
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfigTransformer.java (3 hunks)
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java (3 hunks)
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java (5 hunks)
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java (5 hunks)
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java (4 hunks)

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch clone-KAFKA-18894

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

refacto-visz · 2025-10-01T11:55:20Z

⚠️ No Active Seat

The user @DDShantanuBadmanji does not have an active seat allocated for code reviews.

Please contact your organization admin to assign a seat or upgrade your subscription.

gemini-code-assist · 2025-10-01T11:55:39Z

Summary of Changes

Hello @DDShantanuBadmanji, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors how ConfigProvider instances are handled within Kafka Connect, introducing a Plugin wrapper to standardize their management and enable metrics collection. The primary goal is to enhance the observability of config providers by allowing them to register metrics, while also streamlining their instantiation and lifecycle. The changes touch core configuration and runtime components, ensuring that ConfigProviders are consistently wrapped and their metrics capabilities are properly utilized. The PR title 'Clone kafka 18894' is generic and does not provide specific context for the changes, but the code modifications clearly indicate a focus on plugin extensibility and monitoring.

Highlights

ConfigProvider Plugin Wrapper: Introduced a new Plugin wrapper for ConfigProvider instances across various Kafka Connect components. This refactoring centralizes the management and lifecycle of config providers.
Metrics for ConfigProviders: Enabled ConfigProvider implementations to expose metrics by allowing them to implement the Monitorable interface. This enhances observability by integrating provider-specific metrics into Kafka's metrics system.
Updated API and Usage: Modified AbstractConfig, ConfigTransformer, MirrorMakerConfig, Worker, WorkerConfigTransformer, and Plugins classes to work with Plugin<ConfigProvider> instead of direct ConfigProvider instances, including changes to constructor signatures and method calls.
New Test Utility and Enhanced Testing: Added a new test utility class MonitorableConfigProvider and corresponding tests to thoroughly verify the new metrics functionality and the correct integration of the Plugin wrapper.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

refacto-visz · 2025-10-01T11:56:35Z

⚠️ No Active Seat

The user @DDShantanuBadmanji does not have an active seat allocated for code reviews.

Please contact your organization admin to assign a seat or upgrade your subscription.

gemini-code-assist

Code Review

This pull request introduces a Plugin wrapper for ConfigProvider instances, a refactoring that enables cross-cutting concerns like metrics. The primary benefit is allowing ConfigProviders within a Kafka Connect worker to register their own metrics. The changes are consistently applied across the clients, connect-runtime, and connect-mirror modules. The addition of new tests to validate the metrics functionality is a valuable part of this PR. My review includes one suggestion to improve consistency in how plugin metric tags are created.

gemini-code-assist · 2025-10-01T11:57:20Z

clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java

                ConfigProvider provider = Utils.newInstance(entry.getValue(), ConfigProvider.class);
                provider.configure(configProperties);
-                configProviderInstances.put(entry.getKey(), provider);
+                Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG);


For consistency with how ConfigProvider plugins are created in connect-runtime, it would be good to also include the provider tag here. This ensures that if metrics are enabled for AbstractConfig in the future, the tags will be consistent with those from Connect.

Suggested change

Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG);

Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG, Map.of("provider", entry.getKey()));

Yunyung and others added 12 commits April 7, 2025 12:29

KAFKA-18894: Add KIP-877 support for ConfigProvider

563f347

spotlessApply

08dff59

Update msg in Utils.closeQuietly

9e221e3

Add a test to verify withPluginMetrics is called after configure

1dd8f41

Refactor the test

204c8a9

Refactor

96fd5a6

Add a newline at the end of the file

6ef4001

Fix NPE in transform method

44ecfdb

Remove debug print

e26a06f

Merge branch 'trunk' into KAFKA-18894

27d9a55

Address m1a2st comments

b92a2bb

Update Vagrantfile

5989a26

github-actions bot added clients connect mirror-maker-2 labels Oct 1, 2025

DDShantanuBadmanji closed this Oct 1, 2025

gemini-code-assist bot reviewed Oct 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clone kafka 18894 #34

Clone kafka 18894 #34

DDShantanuBadmanji commented Oct 1, 2025

Uh oh!

coderabbitai bot commented Oct 1, 2025

Rate limit exceeded

Uh oh!

refacto-visz bot commented Oct 1, 2025

Uh oh!

gemini-code-assist bot commented Oct 1, 2025

Uh oh!

refacto-visz bot commented Oct 1, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG);
	Plugin<ConfigProvider> providerPlugin = Plugin.wrapInstance(provider, null, CONFIG_PROVIDERS_CONFIG, Map.of("provider", entry.getKey()));

Clone kafka 18894 #34

Clone kafka 18894 #34

Conversation

DDShantanuBadmanji commented Oct 1, 2025

Uh oh!

coderabbitai bot commented Oct 1, 2025

Rate limit exceeded

Uh oh!

refacto-visz bot commented Oct 1, 2025

Uh oh!

gemini-code-assist bot commented Oct 1, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

refacto-visz bot commented Oct 1, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants